gaborkaszab commented on code in PR #12946:
URL: https://github.com/apache/iceberg/pull/12946#discussion_r2073513250
##########
data/src/test/java/org/apache/iceberg/TestPartitionStatsHandler.java:
##########
@@ -82,6 +65,11 @@
import org.junit.jupiter.api.extension.ExtendWith;
import org.junit.jupiter.api.io.TempDir;
+/**
+ * This test covers {@link PartitionStatsHandler} from the core module. Since
it relies on {@link
Review Comment:
We started discussing some of this on Slack with @ajantha-bhat but for the
record and more visibility:
I think it's a bit off that the Util/Handler implementations are in core
module while (because of the usage of InternalData) it's not feasible to move
the relevant tests to the same place and they remain in the data module. It
might be the symptom of code being on the wrong place.
Would it make sense and would it be feasible to move the implementation code
to the data module so that they can live at the same place as their tests?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
