ebyhr commented on code in PR #12808:
URL: https://github.com/apache/iceberg/pull/12808#discussion_r2074830051
##########
build.gradle:
##########
@@ -657,6 +657,46 @@ project(':iceberg-delta-lake') {
}
}
+project(':iceberg-bigquery') {
+ test {
+ useJUnitPlatform()
+ }
+
+ dependencies {
+ api project(':iceberg-api')
+ implementation project(':iceberg-common')
+ implementation project(':iceberg-core')
+
+ implementation project(path: ':iceberg-bundled-guava', configuration:
'shadow')
+
+ implementation platform(libs.google.libraries.bom)
+ compileOnly "com.google.cloud:google-cloud-storage"
+ implementation "com.google.cloud:google-cloud-bigquery"
+ implementation "com.google.cloud:google-cloud-core"
+
+ compileOnly libs.hadoop3.common
Review Comment:
Note that Hadoop dependency will prevent Trino from adopting BigQuery
metastore catalog since we banned those libraries in
https://github.com/trinodb/trino/issues/15921.
##########
build.gradle:
##########
@@ -657,6 +657,46 @@ project(':iceberg-delta-lake') {
}
}
+project(':iceberg-bigquery') {
+ test {
+ useJUnitPlatform()
+ }
+
+ dependencies {
+ api project(':iceberg-api')
+ implementation project(':iceberg-common')
+ implementation project(':iceberg-core')
+
+ implementation project(path: ':iceberg-bundled-guava', configuration:
'shadow')
+
+ implementation platform(libs.google.libraries.bom)
+ compileOnly "com.google.cloud:google-cloud-storage"
+ implementation "com.google.cloud:google-cloud-bigquery"
+ implementation "com.google.cloud:google-cloud-core"
+
+ compileOnly libs.hadoop3.common
+ compileOnly (libs.hive2.metastore) {
Review Comment:
We can remove `libs.hive2.metastore` dependency once we inline constants of
`org.apache.hadoop.hive.common.StatsSetupConst`, right? Adding this dependency
just for constants looks overkill to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
