Fokko commented on code in PR #1880:
URL: https://github.com/apache/iceberg-python/pull/1880#discussion_r2075056092
##########
pyiceberg/table/update/snapshot.py:
##########
@@ -82,7 +85,10 @@
from pyiceberg.utils.properties import property_as_bool, property_as_int
if TYPE_CHECKING:
- from pyiceberg.table import Transaction
+ pass
Review Comment:
This `if` is there to break circular dependencies. If it is not needed
anymore, we can remove it 👍
##########
tests/expressions/test_literals.py:
##########
@@ -760,7 +760,6 @@ def test_invalid_decimal_conversions() -> None:
def test_invalid_string_conversions() -> None:
assert_invalid_conversions(
literal("abc"),
- [FixedType(1), BinaryType()],
Review Comment:
I don't think we want to remove this one
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
