tomtongue commented on code in PR #12938:
URL: https://github.com/apache/iceberg/pull/12938#discussion_r2087287084
##########
flink/v2.0/flink/src/test/java/org/apache/iceberg/flink/sink/TestIcebergSink.java:
##########
@@ -421,8 +421,9 @@ void testOperatorsUidNameWitUidSuffix() throws Exception {
@TestTemplate
void testErrorOnNullForRequiredField() throws Exception {
- Assume.assumeFalse(
- "ORC file format supports null values even for required fields.",
format == FileFormat.ORC);
+ assumeThat(format)
+ .as("ORC file format supports null values even for required fields.")
+ .isEqualTo(FileFormat.ORC);
Review Comment:
@nastra Sorry one thing, I think this should be `isNotEqualTo` because the
current one uses `assumeFalse`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
