zeroshade commented on code in PR #414:
URL: https://github.com/apache/iceberg-go/pull/414#discussion_r2096347983
##########
catalog/sql/sql.go:
##########
@@ -133,8 +136,12 @@ type sqlIcebergTable struct {
CatalogName string `bun:",pk"`
TableNamespace string `bun:",pk"`
TableName string `bun:",pk"`
+ IcebergType string // "TABLE" or "VIEW"
MetadataLocation sql.NullString
PreviousMetadataLocation sql.NullString
+ ViewSQL sql.NullString // Only populated for views
+ SchemaJSON sql.NullString // Only populated for views
+ Properties map[string]string `bun:"type:jsonb"` // Only
populated for views
Review Comment:
You're still adding extra fields that shouldn't be there and don't get
populated for views at all. We need to remove them so that we're complying with
the way the JDBC catalog works.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
