Fokko commented on code in PR #2013:
URL: https://github.com/apache/iceberg-python/pull/2013#discussion_r2096362214
##########
pyiceberg/catalog/hive.py:
##########
@@ -541,6 +548,7 @@ def commit_table(
hive_table.parameters = _construct_parameters(
metadata_location=updated_staged_table.metadata_location,
previous_metadata_location=current_table.metadata_location,
+ metadata_properties=updated_staged_table.properties,
Review Comment:
We also invoke this at line 363, should we also pass in the properties there?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
