jonathanc-n commented on code in PR #1172:
URL: https://github.com/apache/iceberg-rust/pull/1172#discussion_r2098900355
##########
crates/iceberg/src/spec/schema/mod.rs:
##########
@@ -21,6 +21,7 @@ use std::collections::{HashMap, HashSet};
use std::fmt::{Display, Formatter};
use std::sync::Arc;
+mod update;
Review Comment:
I think it is best practice to infer this from the folder name. For example
codebases such as Datafusion or iceberg-rust, files named metadata are just
called `metadata.rs` under different folders (ex. manifest, puffin, etc.)
Unless it becomes ambiguous with other names in the same folder
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
