manuzhang commented on code in PR #13127:
URL: https://github.com/apache/iceberg/pull/13127#discussion_r2102701620
##########
docs/docs/flink-writes.md:
##########
@@ -75,7 +75,7 @@ Iceberg supports `UPSERT` based on the primary key when
writing data into v2 tab
```
!!! info
- OVERWRITE and UPSERT can't be set together. In UPSERT mode, if the table
is partitioned, the partition fields should be included in equality fields.
+ OVERWRITE and UPSERT can't be set together. In UPSERT mode, if the table
is partitioned, the source columns of partition fields should be included in
equality fields.
Review Comment:
Basically descriptions of the following codes
https://github.com/apache/iceberg/blob/91dff9886e6e6c494f6a970129f4c08487c98a0d/flink/v2.0/flink/src/main/java/org/apache/iceberg/flink/sink/FlinkSink.java#L537-L545
I just noticed the error message is not accurate either. For a table with
partition field `days(ts)`, it's `ts` that's required to be included in
equality fields. We can't add `days(ts)` to equality fields.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
