kevinjqliu commented on code in PR #1366:
URL: https://github.com/apache/iceberg-rust/pull/1366#discussion_r2102745732
##########
scripts/dependencies.py:
##########
@@ -22,34 +22,41 @@
DIRS = [
"crates/iceberg",
-
- "crates/catalog/glue", "crates/catalog/hms",
- "crates/catalog/memory", "crates/catalog/rest",
+ "crates/catalog/glue",
+ "crates/catalog/hms",
+ "crates/catalog/memory",
+ "crates/catalog/rest",
"crates/catalog/sql",
-
"crates/integrations/datafusion",
-
- "bindings/python"
+ "bindings/python",
Review Comment:
I was considering `cargo metadata` and `find . -name Cargo.toml -exec
dirname {} \;` but landed with the python solution. `cargo metadata` skips the
python binding subdir, `find` and the python solution is more future proof
LMK what you think!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
