elphastori commented on code in PR #13129:
URL: https://github.com/apache/iceberg/pull/13129#discussion_r2105535540
##########
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java:
##########
@@ -565,13 +568,16 @@ public List<Namespace> listNamespaces(SessionContext
context, Namespace namespac
}
ImmutableList.Builder<Namespace> namespaces = ImmutableList.builder();
- String pageToken = "";
+ String pageToken = null;
if (pageSize != null) {
queryParams.put("pageSize", String.valueOf(pageSize));
}
do {
- queryParams.put("pageToken", pageToken);
+ if (pageToken != null) {
+ queryParams.put("pageToken", pageToken);
+ }
+
Review Comment:
It's a nice thought experiment, but if we remove the condition here, a null
check will throw a NullPointerException while attempting to construct the HTTP
request.
Instead of having the null check in the HTTP client, we could filter out
keys with null values, but I prefer the null check.
Omitting the parameter altogether is currently the only way to relay that
the value is exactly `null` to the server.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
