amogh-jahagirdar commented on code in PR #12928:
URL: https://github.com/apache/iceberg/pull/12928#discussion_r2106432131
##########
spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestRowLevelOperationsWithLineage.java:
##########
@@ -91,7 +91,6 @@ public void beforeEach() {
assumeThat(formatVersion).isGreaterThanOrEqualTo(3);
// ToDo: Remove these as row lineage inheritance gets implemented in the
other readers
assumeThat(fileFormat).isEqualTo(FileFormat.PARQUET);
- assumeThat(vectorized).isFalse();
Review Comment:
I added a test which tests a lot of records (25000, it takes 6 seconds to
run locally). I didn't do the "only update even" records approach since it made
the merge a bit opaque to understand. I followed what I already did in the
previous test which updates and inserts a single record. The benefit now is we
can essentially make sure that reading multiple batches with all the
inheritance logic works and there's no weird reuse bugs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
