zeroshade commented on code in PR #441:
URL: https://github.com/apache/iceberg-go/pull/441#discussion_r2109571065
##########
catalog/glue/options.go:
##########
@@ -18,13 +18,18 @@
package glue
import (
+ "context"
+
+ "github.com/apache/iceberg-go/io"
"github.com/aws/aws-sdk-go-v2/aws"
)
type AwsProperties map[string]string
type Option func(*options)
+type FSLoaderFunction func(ctx context.Context, props map[string]string,
location string) (io.IO, error)
Review Comment:
Rather than doing this, would it make more sense to set up a registry with
the `io.IO` similar to the catalog registry we have? Where the scheme can be
used to register specific handlers for file systems?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
