wypoon commented on code in PR #13168:
URL: https://github.com/apache/iceberg/pull/13168#discussion_r2110750268
##########
spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/source/SparkMicroBatchStream.java:
##########
@@ -434,8 +434,14 @@ public Offset latestOffset(Offset startOffset, ReadLimit
limit) {
// if everything was OK and we consumed complete snapshot then move to
next snapshot
if (shouldContinueReading) {
+ Snapshot nextValid = nextValidSnapshot(curSnapshot);
+ if (nextValid == null) {
+ // nextValid implies all the remaining snapshots should be skipped.
+ break;
Review Comment:
In the original, there was a
```
shouldContinueReading = false;
```
before the `break`, but that was removed as unnecessary by
https://github.com/apache/iceberg/commit/afda8be25652d44d9339a79c6797b6bf20c55bd6.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
