pvary commented on code in PR #12254:
URL: https://github.com/apache/iceberg/pull/12254#discussion_r2110925431
##########
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestRemoveOrphanFilesAction.java:
##########
@@ -107,9 +115,12 @@ public abstract class TestRemoveOrphanFilesAction extends
TestBase {
protected Map<String, String> properties;
@Parameter private int formatVersion;
- @Parameters(name = "formatVersion = {0}")
+ @Parameter(index = 1)
+ private boolean usePrefixListing;
+
+ @Parameters(name = "formatVersion = {0}, usePrefixListing = {1}")
protected static List<Object> parameters() {
- return Arrays.asList(2, 3);
+ return Arrays.asList(new Object[] {2, true}, new Object[] {2, false}, new
Object[] {3, false});
Review Comment:
I have explicitly asked to decrease the number of tests, as these tests are
costly, and the listing charge has nothing to do with the format version.
There could be arguments for any version of testing matrix, but if we spend
too much time on it, then we should just enable the whole matrix and wait a bit
more for the CI to finish 😉
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
