ajantha-bhat commented on code in PR #13163:
URL: https://github.com/apache/iceberg/pull/13163#discussion_r2111937967
##########
core/src/test/java/org/apache/iceberg/PartitionStatsHandlerTestBase.java:
##########
@@ -441,6 +441,52 @@ public void testPartitionStats() throws Exception {
snapshot1.snapshotId()));
}
+ @Test
+ public void testCopyOnWriteDelete() throws Exception {
+ Table testTable =
+ TestTables.create(tempDir("my_test"), "my_test", SCHEMA, SPEC, 2,
fileFormatProperty);
+
+ DataFile dataFile1 =
+ DataFiles.builder(SPEC)
+ .withPath("/df1.parquet")
+ .withPartitionPath("c2=a/c3=a")
+ .withFileSizeInBytes(10)
+ .withRecordCount(1)
+ .build();
+ DataFile dataFile2 =
+ DataFiles.builder(SPEC)
+ .withPath("/df2.parquet")
+ .withPartitionPath("c2=b/c3=b")
+ .withFileSizeInBytes(10)
+ .withRecordCount(1)
+ .build();
+
+ testTable.newAppend().appendFile(dataFile1).appendFile(dataFile2).commit();
+
+ PartitionStatisticsFile statisticsFile =
+ PartitionStatsHandler.computeAndWriteStatsFile(testTable);
+
testTable.updatePartitionStatistics().setPartitionStatistics(statisticsFile).commit();
+
+ assertThat(
+ PartitionStatsHandler.readPartitionStatsFile(
+
PartitionStatsHandler.schema(Partitioning.partitionType(testTable)),
+ Files.localInput(statisticsFile.path())))
+ .allMatch(s -> (s.dataRecordCount() != 0 && s.dataFileCount() != 0));
+
+ testTable.newDelete().deleteFile(dataFile1).commit();
+ testTable.newDelete().deleteFile(dataFile2).commit();
+
+ PartitionStatisticsFile statisticsFileNew =
+ PartitionStatsHandler.computeAndWriteStatsFile(testTable);
+
+ // stats must be decremented to zero as all the files removed from table.
+ assertThat(
+ PartitionStatsHandler.readPartitionStatsFile(
+
PartitionStatsHandler.schema(Partitioning.partitionType(testTable)),
+ Files.localInput(statisticsFileNew.path())))
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
