corleyma commented on code in PR #1998:
URL: https://github.com/apache/iceberg-python/pull/1998#discussion_r2116504450
##########
pyiceberg/catalog/rest/__init__.py:
##########
@@ -678,7 +679,16 @@ def list_tables(self, namespace: Union[str, Identifier])
-> List[Identifier]:
@retry(**_RETRY_ARGS)
def load_table(self, identifier: Union[str, Identifier]) -> Table:
- response = self._session.get(self.url(Endpoints.load_table,
prefixed=True, **self._split_identifier_for_path(identifier)))
+ params = {}
+ if mode := self.properties.get(SNAPSHOT_LOADING_MODE):
Review Comment:
Sorry for coming back to this late.
Maybe the base interface should just change to accept kwargs, and we can add
here some implementation-specific kwargs for REST catalog?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
