kevinjqliu commented on code in PR #447:
URL: https://github.com/apache/iceberg-go/pull/447#discussion_r2119456069
##########
dev/release/release_rc.sh:
##########
@@ -102,11 +102,22 @@ if [ "${RELEASE_SIGN}" -gt 0 ]; then
cd "${id}"
gpg --armor --output "${tar_gz}.asc" --detach-sig "${tar_gz}"
sha512sum "${tar_gz}" > "${tar_gz}.sha512"
+ echo "Add signature and checksum to GitHub release"
+ gh release upload "${rc_tag}" \
+ --clobber \
+ --repo "${repository}" \
+ "${tar_gz}".asc "${tar_gz}.sha512"
Review Comment:
btw, the gh release already generates the sha512 file.
```
gh release download v0.3.0-rc0 --repo apache/iceberg-go
```
downloads
- apache-iceberg-go-0.3.0-rc0.tar.gz
- apache-iceberg-go-0.3.0-rc0.tar.gz.sha512
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
