nastra commented on code in PR #13129:
URL: https://github.com/apache/iceberg/pull/13129#discussion_r2120539119
##########
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java:
##########
@@ -268,13 +268,12 @@ public List<TableIdentifier> listTables(SessionContext
context, Namespace ns) {
checkNamespaceIsValid(ns);
Map<String, String> queryParams = Maps.newHashMap();
ImmutableList.Builder<TableIdentifier> tables = ImmutableList.builder();
- String pageToken = "";
+ String pageToken = null;
Review Comment:
changing this here will break when the client talks to an older server that
expects the `pageToken` to be an empty string on the first pagination attempt
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
