nastra commented on issue #13119:
URL: https://github.com/apache/iceberg/issues/13119#issuecomment-2929697615
> Specifically when `pageToken` is omitted and `pageSize` is set
(`http://localhost:8181/v1/namespaces/default/tables?pageSize=1`), the server
with pagination support should return at most 1 record
I feel like the Impl currently behaves as defined by the Spec (although the
behavior isn't dev friendly). The spec says
> Clients may initiate the first paginated request by sending an empty query
parameter `pageToken` to the server
Looking deeper into this, I believe we wanted to disambiguate what **empty**
means via `allowEmptyValue`, but I agree that this rather adds more confusion
around the meaning of **empty** and there's
https://github.com/OAI/OpenAPI-Specification/issues/1573 that essentially
arrives at
> In PR https://github.com/OAI/OpenAPI-Specification/issues/1573, targeted
for the 3.0.2 patch revision, we have made use of allowEmptyValue NOT
RECOMMENDED. Consensus on the TSC is that this feature has ambiguous meanings,
and interacts in awkward ways with Schema Object and Parameter style. See
previous comments in this issue thread for more details.
> We can revisit in OpenAPI 4.x if there's a good use case.
That being said, we should add a DISCUSS thread on the mailing list to
remove usage of `allowEmptyValue` (due to
https://github.com/OAI/OpenAPI-Specification/pull/1632) and to disambiguate the
behavior. @elphastori could you please do that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
