kadai0308 commented on code in PR #2013:
URL: https://github.com/apache/iceberg-python/pull/2013#discussion_r2123307364
##########
tests/integration/test_reads.py:
##########
@@ -111,6 +112,23 @@ def test_table_properties(catalog: Catalog) -> None:
table.transaction().set_properties(property_name=None).commit_transaction()
Review Comment:
Thanks for your review and suggestion.
Yes, this is also confuse me when I develop this PR. Then I found:
https://github.com/kadai0308/iceberg-python/blob/ff149e8e9d8e0b8dd9e74158b1fb89724833b5b4/pyiceberg/catalog/hive.py#L342-L344
So to make sure it did write to the HMS properties, I need to new a
`hive_client` to get the `hive_table.parameters`:
```
hive_client: _HiveClient = _HiveClient(catalog.properties["uri"])
with hive_client as open_client:
hive_table = open_client.get_table(*TABLE_NAME)
assert hive_table.parameters.get("abc") == "def"
assert hive_table.parameters.get("p1") == "123"
```
instead of just test like:
```
table = create_table(catalog)
assert table.properties == dict(p1="123", **DEFAULT_PROPERTIES)
```
I think I can also help with
https://github.com/apache/iceberg-python/issues/2064.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
