nastra commented on code in PR #13223:
URL: https://github.com/apache/iceberg/pull/13223#discussion_r2126083409
##########
core/src/test/java/org/apache/iceberg/catalog/CatalogTests.java:
##########
@@ -949,14 +951,37 @@ public void testLoadMetadataTable() {
assertThat(table.name()).isEqualTo(catalog.name() + "." + metaIdent);
}
- @Test
- public void testLoadMissingTable() {
+ @ParameterizedTest
+ @MethodSource("nonExistentTableIdentifiers")
+ public void testLoadMissingTable(TableIdentifier identifier) {
C catalog = catalog();
- assertThat(catalog.tableExists(TBL)).as("Table should not
exist").isFalse();
- assertThatThrownBy(() -> catalog.loadTable(TBL))
+ assumeThat(supportsEmptyNamespace() || !identifier.namespace().isEmpty())
Review Comment:
maybe just add a new test method, as otherwise this is effectively removing
some test coverage from catalogs that don't support empty/nested namespaces
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
