rdblue commented on a change in pull request #1478:
URL: https://github.com/apache/iceberg/pull/1478#discussion_r496948397
##########
File path:
mr/src/test/java/org/apache/iceberg/mr/hive/serde/objectinspector/TestIcebergObjectInspector.java
##########
@@ -90,7 +91,13 @@ public void testIcebergObjectInspector() {
Assert.assertEquals(3, dateField.getFieldID());
Assert.assertEquals("date_field", dateField.getFieldName());
Assert.assertEquals("date comment", dateField.getFieldComment());
- Assert.assertEquals(IcebergDateObjectInspector.get(),
dateField.getFieldObjectInspector());
+ if (MetastoreUtil.hive3PresentOnClasspath()) {
+ Assert.assertEquals(
+
"org.apache.iceberg.mr.hive.serde.objectinspector.IcebergDateObjectInspectorHive3",
+ dateField.getFieldObjectInspector().getClass().getName());
Review comment:
I'd prefer using the same assertion, but with a different class name.
But this is really minor if tests are passing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
