bryanck commented on code in PR #13190:
URL: https://github.com/apache/iceberg/pull/13190#discussion_r2126836261
##########
core/src/test/java/org/apache/iceberg/rest/TestHTTPClient.java:
##########
@@ -332,6 +345,48 @@ public void testMaxConnectionSettingsFromDefaults() {
.isEqualTo(HTTPClient.REST_MAX_CONNECTIONS_PER_ROUTE_DEFAULT);
}
+ @Test
+ public void testLoadTLSConfigurer() {
+ Map<String, String> properties =
+ ImmutableMap.of(HTTPClient.REST_TLS_CONFIGURER,
DefaultTLSConfigurer.class.getName());
+ HttpClientConnectionManager connectionManager =
+ HTTPClient.configureConnectionManager(properties);
+
assertThat(connectionManager).isInstanceOf(PoolingHttpClientConnectionManager.class);
+ assertThat(DefaultTLSConfigurer.count).isEqualTo(1);
+ }
+
+ @Test
+ public void testLoadTLSConfigurer_NoArgConstructorNotFound() {
Review Comment:
Yes, agreed, the underscore convention isn't used in this test class anyway
so I removed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
