rdblue commented on code in PR #13039:
URL: https://github.com/apache/iceberg/pull/13039#discussion_r2127443855
##########
core/src/main/java/org/apache/iceberg/MetricsConfig.java:
##########
@@ -123,23 +223,31 @@ private static MetricsConfig from(Map<String, String>
props, Schema schema, Sort
// Handle user override of default mode
MetricsMode defaultMode;
String configuredDefault = props.get(DEFAULT_WRITE_METRICS_MODE);
+
+ // TODO: Verify this is correct with user supplied default or not, why
shouldn't it be bounded.
+ // why was it not before?
Review Comment:
I think this behavior is correct. A default is applied to all columns.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
