CuteChuanChuan commented on issue #13178: URL: https://github.com/apache/iceberg/issues/13178#issuecomment-2945076449
@nastra `ImmutableEnumChecker` errorprone warning msg as follows: ``` iceberg/api/src/main/java/org/apache/iceberg/transforms/Timestamps.java:47: warning: [ImmutableEnumChecker] enums should be immutable: 'Timestamps' has field 'apply' of type 'org.apache.iceberg.util.SerializableFunction<java.lang.Long,java.lang.Integer>', the declaration of type 'org.apache.iceberg.util.SerializableFunction<java.lang.Long,java.lang.Integer>' is not annotated with @com.google.errorprone.annotations.Immutable private final SerializableFunction<Long, Integer> apply; ^ (see [https://errorprone.info/bugpattern/ImmutableEnumChecker)`](https://errorprone.info/bugpattern/ImmutableEnumChecker)%60) [ImmutableEnumChecker] enums should be immutable: 'Timestamps' has field 'apply' of type 'org.apache.iceberg.util.SerializableFunction<java.lang.Long,java.lang.Integer>', the declaration of type 'org.apache.iceberg.util.SerializableFunction<java.lang.Long,java.lang.Integer>' is not annotated with @com.google.errorprone.annotations.Immutable ``` I will address the `MixedMutabilityReturnType` (introduced in commit b8cc8eb8), and the `ObjectsHashCodePrimitive` is already solved in my draft PR. Thanks for the heads-up! @ajantha-bhat Thank you for the guidance on `ImmutableEnumChecker`, and I will give it a try. Regarding the `DangerousParallelStreamUsage`, I will also try using `Tasks.foreach` to align with the project pattern. Thanks for pointing this out. After processing all the errorprone warnings, I will submit the PR ASAP. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
