MisterRaindrop commented on PR #119: URL: https://github.com/apache/iceberg-cpp/pull/119#issuecomment-2947983602
If there is no break statement in a certain case, the program may execute the Unreachable() function, which is not what we want (what we want is for each case to handle the situation and then exit, so we must be careful with the break statements). Additionally, when the compiler does not support exhaustive checking, we cannot know at compile - time if there are any missing cases. Of course, if it is indeed placed later, I can also make modifications. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
