Shreyas220 commented on PR #431:
URL: https://github.com/apache/iceberg-go/pull/431#issuecomment-2952849572
Thanks a lot @nandorKollar @zeroshade @laskoviymishka for your review!!
really appreciate it!
I have tried to address majority of them, a couple of them are remaining
summary is
- no panics returning error now
- moved updateschema from table to transaction
- changes delete, add , updates to map of int (ids)
- simplified addcolumn logic
- using 1 function for updates (@zeroshade your review here if this is what
you were looking for )
- added tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
