Fokko commented on code in PR #2059: URL: https://github.com/apache/iceberg-python/pull/2059#discussion_r2134806252
########## pyiceberg/catalog/dynamodb.py: ########## @@ -652,6 +654,19 @@ def _convert_dynamo_table_item_to_iceberg_table(self, dynamo_table_item: Dict[st catalog=self, ) + def _get_default_warehouse_location(self, database_name: str, table_name: str) -> str: Review Comment: Looks like we're repeating this a couple of times, should we move this into `pyiceberg/catalog/__init__.py`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org