manuzhang commented on code in PR #13281:
URL: https://github.com/apache/iceberg/pull/13281#discussion_r2137523558
##########
core/src/main/java/org/apache/iceberg/actions/SizeBasedFileRewritePlanner.java:
##########
@@ -174,7 +174,7 @@ protected Iterable<List<T>> planFileGroups(Iterable<T>
tasks) {
}
protected boolean enoughInputFiles(List<T> group) {
- return group.size() > 1 && group.size() >= minInputFiles;
+ return group.size() > minInputFiles;
Review Comment:
We ensure `minInputFiles > 0`.
```java
private int minInputFiles(Map<String, String> options) {
int value = PropertyUtil.propertyAsInt(options, MIN_INPUT_FILES,
MIN_INPUT_FILES_DEFAULT);
Preconditions.checkArgument(
value > 0, "'%s' is set to %s but must be > 0", MIN_INPUT_FILES,
value);
return value;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
