RussellSpitzer commented on code in PR #13284:
URL: https://github.com/apache/iceberg/pull/13284#discussion_r2143358436
##########
api/src/test/java/org/apache/iceberg/variants/VariantTestUtil.java:
##########
@@ -107,6 +121,15 @@ static SerializedPrimitive createString(String string) {
return SerializedPrimitive.from(buffer, buffer.get(0));
}
+ /** Creates a short string primitive of max 63 chars to use only 1 header */
+ static SerializedShortString createShortString(String string) {
+ byte[] utf8 = string.getBytes(StandardCharsets.UTF_8);
Review Comment:
~Create string above should have a check that the length is 64 or greater~
I actually think we shouldn't have a precondition for createString,
createString is valid with short strings as well only shortString is invalid
with long strings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
