CTTY commented on code in PR #1448:
URL: https://github.com/apache/iceberg-rust/pull/1448#discussion_r2151080053
##########
crates/iceberg/src/transaction/append.rs:
##########
@@ -87,76 +169,45 @@ impl FastAppendAction {
/// Specifically, schema compatibility checks and support for adding to
partitioned tables
/// have not yet been implemented.
#[allow(dead_code)]
- async fn add_parquet_files(mut self, file_path: Vec<String>) ->
Result<Transaction> {
- if !self
- .snapshot_produce_action
- .tx
- .current_table
- .metadata()
- .default_spec
- .is_unpartitioned()
- {
+ async fn add_parquet_files(self, table: &Table, file_path: Vec<String>) ->
Result<Self> {
Review Comment:
I'm wondering if we actually need this as an API. I feel like it's cleaner
to provide a helper method to convert parquet files to `DataFile`s, which can
be passed to `add_data_files` directly later.
Would appreciate any input here!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
