singhpk234 commented on code in PR #13327:
URL: https://github.com/apache/iceberg/pull/13327#discussion_r2154822436
##########
core/src/main/java/org/apache/iceberg/actions/BinPackRewriteFilePlanner.java:
##########
@@ -291,7 +306,9 @@ private StructLikeMap<List<List<FileScanTask>>>
planFileGroups() {
scan = scan.useSnapshot(snapshotId);
}
- CloseableIterable<FileScanTask> fileScanTasks = scan.planFiles();
+ CloseableIterable<FileScanTask> fileScanTasks =
+ CloseableIterable.filter(
+ scan.planFiles(), fileScanTask ->
fileFilter.test(fileScanTask.file()));
Review Comment:
mostly comming from case where data file is local and delete files remote,
we can check the deletes files here if we agree on path based filters rather
than just data file filter WDYT ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
