amogh-jahagirdar commented on code in PR #13352:
URL: https://github.com/apache/iceberg/pull/13352#discussion_r2155824363
##########
core/src/test/java/org/apache/iceberg/rest/TestExponentialHttpRequestRetryStrategy.java:
##########
@@ -207,16 +198,22 @@ public void invalidRetryAfterHeader() {
}
@Test
- public void testRetryBadGateway() {
- HttpContext context = new BasicHttpContext();
- BasicHttpResponse response502 = new BasicHttpResponse(502, "Bad gateway
failure");
- assertThat(retryStrategy.retryRequest(response502, 3, context)).isTrue();
- }
+ public void testRetryHappensOnAcceptableStatusCodes() {
Review Comment:
Is it possible to separate into two separate tests, one for acceptable codes
and another for status codes we do not want to retry? and then could we
parameterize that via `@ParameterizedTest` with a MethodSource of the codes?
Then it becomes clear which codes we're testing and their expectations, along
with reducing a bit of duplication
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
