Xuanwo commented on code in PR #1383:
URL: https://github.com/apache/iceberg-rust/pull/1383#discussion_r2158367942
##########
crates/iceberg/src/error.rs:
##########
@@ -134,6 +134,8 @@ pub struct Error {
source: Option<anyhow::Error>,
backtrace: Backtrace,
+
+ retryable: bool,
Review Comment:
> On the other hand, I think adding a dedicated `ErrorKind` like
`CommitFailed` for commit conflicts doesn't conflict with the idea of having an
`ErrorStatus`
I don't think we should have an error type called `CommitFailed`, since
users can't really do anything about it.
I still think it would be better to add a `status` or `temporary` field to
`Error` to make it more orthogonal than `ErrorKind`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
