jayceslesar commented on code in PR #1958:
URL: https://github.com/apache/iceberg-python/pull/1958#discussion_r2160070215
##########
pyiceberg/table/inspect.py:
##########
@@ -678,6 +689,32 @@ def all_manifests(self) -> "pa.Table":
)
return pa.concat_tables(manifests_by_snapshots)
+ def _all_known_files(self) -> dict[str, set[str]]:
+ """Get all the known files in the table.
+
+ Returns:
+ dict of {file_type: set of file paths} for each file type.
+ """
+ snapshots = self.tbl.snapshots()
+
+ _all_known_files = {}
+ _all_known_files["manifests"] =
set(self.all_manifests(snapshots)["path"].to_pylist())
+ _all_known_files["manifest_lists"] = {snapshot.manifest_list for
snapshot in snapshots}
+ _all_known_files["statistics"] = {statistic.statistics_path for
statistic in self.tbl.metadata.statistics}
+
+ metadata_files = {entry.metadata_file for entry in
self.tbl.metadata.metadata_log}
+ metadata_files.add(self.tbl.metadata_location) # Include current
metadata file
+ _all_known_files["metadata"] = metadata_files
+
+ executor = ExecutorFactory.get_or_create()
+ snapshot_ids = [snapshot.snapshot_id for snapshot in snapshots]
+ files_by_snapshots: Iterator[Set[str]] = executor.map(
+ lambda snapshot_id:
set(self.files(snapshot_id)["file_path"].to_pylist()), snapshot_ids
Review Comment:
Yeah I think there are a lot of places where we arbitrarily use one over the
other and imo would be nice to standardize. Probably out of scope for this PR
but I think would definitely clean things up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
