nastra commented on code in PR #13347:
URL: https://github.com/apache/iceberg/pull/13347#discussion_r2163957148
##########
aws/src/integration/java/org/apache/iceberg/aws/s3/S3TestUtil.java:
##########
@@ -29,4 +35,18 @@ public static String getBucketFromUri(String s3Uri) {
public static String getKeyFromUri(String s3Uri) {
return new S3URI(s3Uri).key();
}
+
+ /**
+ * Skip a test if the Analytics Accelerator Library for Amazon S3 is enabled.
+ *
+ * @param properties properties to probe
+ */
+ public static void skipIfAnalyticsAcceleratorEnabled(
+ S3FileIOProperties properties, String message) {
+ boolean isAcceleratorEnabled =
properties.isS3AnalyticsAcceleratorEnabled();
+ if (isAcceleratorEnabled) {
+ LOG.warn(message);
+ }
+
Assumptions.assumeThat(!isAcceleratorEnabled).describedAs(message).isTrue();
Review Comment:
this should be a static import. I'm surprised that checkstyle didn't
complain here about this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
