sdd commented on code in PR #1011:
URL: https://github.com/apache/iceberg-rust/pull/1011#discussion_r2175684449
##########
crates/iceberg/src/delete_vector.rs:
##########
@@ -38,6 +38,15 @@ impl DeleteVector {
let outer = self.inner.bitmaps();
DeleteVectorIterator { outer, inner: None }
}
+
+ pub fn insert(&mut self, pos: u64) -> bool {
+ self.inner.insert(pos)
+ }
+
+ #[allow(unused)]
Review Comment:
I pushed a change with the removal of this to
https://github.com/apache/iceberg-rust/pull/1017 but its removal [causes the CI
to
fail](https://github.com/apache/iceberg-rust/actions/runs/15981017646/job/45075185262?pr=1017),
complaining that "len is never used".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
