zhjwpku commented on code in PR #134:
URL: https://github.com/apache/iceberg-cpp/pull/134#discussion_r2177012992
##########
src/iceberg/type.h:
##########
@@ -446,4 +446,48 @@ class ICEBERG_EXPORT UuidType : public PrimitiveType {
/// @}
+/// \defgroup type-factories Factory functions for creating primitive data
types
+///
+/// Factory functions for creating primitive data types
+/// @{
+
+/// \brief Return a BooleanType instance.
+ICEBERG_EXPORT const std::shared_ptr<BooleanType>& boolean();
+/// \brief Return an IntType instance.
+ICEBERG_EXPORT const std::shared_ptr<IntType>& int32();
+/// \brief Return a LongType instance.
+ICEBERG_EXPORT const std::shared_ptr<LongType>& int64();
+/// \brief Return a FloatType instance.
+ICEBERG_EXPORT const std::shared_ptr<FloatType>& float32();
+/// \brief Return a DoubleType instance.
+ICEBERG_EXPORT const std::shared_ptr<DoubleType>& float64();
+/// \brief Return a DateType instance.
+ICEBERG_EXPORT const std::shared_ptr<DateType>& date();
+/// \brief Return a TimeType instance.
+ICEBERG_EXPORT const std::shared_ptr<TimeType>& time();
+/// \brief Return a TimestampType instance.
+ICEBERG_EXPORT const std::shared_ptr<TimestampType>& timestamp();
+/// \brief Return a TimestampTzType instance.
+ICEBERG_EXPORT const std::shared_ptr<TimestampTzType>& timestamp_tz();
+/// \brief Return a BinaryType instance.
+ICEBERG_EXPORT const std::shared_ptr<BinaryType>& binary();
+/// \brief Return a StringType instance.
+ICEBERG_EXPORT const std::shared_ptr<StringType>& string();
+/// \brief Return a UuidType instance.
+ICEBERG_EXPORT const std::shared_ptr<UuidType>& uuid();
+
+/// \brief Create a DecimalType with the given precision and scale.
+/// \param precision The number of decimal digits (max 38).
+/// \param scale The number of decimal digits after the decimal point (0 to
+/// precision).
Review Comment:
Sure, I will remove the content in parentheses to avoid any confusion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
