wgtmac commented on code in PR #133:
URL: https://github.com/apache/iceberg-cpp/pull/133#discussion_r2177747580
##########
src/iceberg/file_reader.h:
##########
@@ -50,66 +49,11 @@ class ICEBERG_EXPORT Reader {
/// \brief Read next data from file.
///
- /// \return std::monostate if the reader has no more data, otherwise
`ArrowArray` or
- /// `StructLike` depending on the data layout by the reader implementation.
- using Data =
- std::variant<std::monostate, ArrowArray, std::reference_wrapper<const
StructLike>>;
- virtual Result<Data> Next() = 0;
+ /// \return std::nullopt if the reader has no more data, otherwise
`ArrowArray`.
Review Comment:
The contract of `ArrowArray` is that data can be empty but it does not mean
the end of file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
