amogh-jahagirdar commented on code in PR #13435:
URL: https://github.com/apache/iceberg/pull/13435#discussion_r2178669292
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/SparkScanBuilder.java:
##########
@@ -381,7 +381,7 @@ private Schema
calculateMetadataSchema(List<Types.NestedField> metaColumnFields)
AtomicInteger nextId = new AtomicInteger();
return new Schema(
metaColumnFields,
- table.schema().identifierFieldIds(),
Review Comment:
Nit: I think for consistency with other places we should do
`ImmutableSet.of()`, but it's nbd from my side.
##########
spark/v4.0/spark/src/main/java/org/apache/iceberg/spark/source/SparkScanBuilder.java:
##########
@@ -381,7 +381,7 @@ private Schema
calculateMetadataSchema(List<Types.NestedField> metaColumnFields)
AtomicInteger nextId = new AtomicInteger();
return new Schema(
metaColumnFields,
- table.schema().identifierFieldIds(),
+ Set.of(),
Review Comment:
I think I agree we probably should not be passing through the identifier
fields here but the new test added still passes even without this fix. Are we
sure this is the right place or is there another cause? Or perhaps there are
more specific conditions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
