kumarpritam863 commented on PR #13357: URL: https://github.com/apache/iceberg/pull/13357#issuecomment-3028094973
By moving this call, we’re essentially saving just a single initialization in most scenarios — the first call sets up the catalog, and subsequent ones simply reuse it. However, this approach feels slightly like an anti-pattern, as the catalog is conceptually and operationally tied to the task, which is where the actual business logic interacts with it. Embedding catalog initialization at the connector level not only increases the connector's responsibility but can also make it more susceptible to failures. In practice, most observability and alerting systems focus on task-level failures rather than connector-level ones, so this shift could make failure detection and recovery harder to trace and act upon. Additionally, the underlying issue seems tightly coupled with the JDBC behavior. Given that, I believe a more robust and localized solution might be to handle the exception directly [here](https://github.com/apache/iceberg/blob/404c8057275c9cfe204f2c7cc61114c128fbf759/core/src/main/java/org/apache/iceberg/jdbc/JdbcCatalog.java#L204), where it originates. Curious to hear your thoughts on this, @bryanck — what do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
