pvary commented on code in PR #13426:
URL: https://github.com/apache/iceberg/pull/13426#discussion_r2185161497
##########
flink/v2.0/flink/src/main/java/org/apache/iceberg/flink/actions/Actions.java:
##########
@@ -32,21 +35,52 @@ public class Actions {
private final StreamExecutionEnvironment env;
private final Table table;
+ private final TableLoader tableLoader;
+ @Deprecated
private Actions(StreamExecutionEnvironment env, Table table) {
this.env = env;
this.table = table;
+ this.tableLoader = null;
}
+ private Actions(StreamExecutionEnvironment env, TableLoader tableLoader) {
+ this.env = env;
+ this.tableLoader = tableLoader;
+ if (!tableLoader.isOpen()) {
+ tableLoader.open();
+ }
+
+ this.table = tableLoader.loadTable();
+ }
+
+ @Deprecated
public static Actions forTable(StreamExecutionEnvironment env, Table table) {
return new Actions(env, table);
}
+ public static Actions forTable(StreamExecutionEnvironment env, TableLoader
tableLoader) {
Review Comment:
nit: forTableLoader
##########
flink/v2.0/flink/src/main/java/org/apache/iceberg/flink/actions/Actions.java:
##########
@@ -32,21 +35,52 @@ public class Actions {
private final StreamExecutionEnvironment env;
private final Table table;
+ private final TableLoader tableLoader;
+ @Deprecated
private Actions(StreamExecutionEnvironment env, Table table) {
this.env = env;
this.table = table;
+ this.tableLoader = null;
}
+ private Actions(StreamExecutionEnvironment env, TableLoader tableLoader) {
+ this.env = env;
+ this.tableLoader = tableLoader;
+ if (!tableLoader.isOpen()) {
+ tableLoader.open();
+ }
+
+ this.table = tableLoader.loadTable();
+ }
+
+ @Deprecated
public static Actions forTable(StreamExecutionEnvironment env, Table table) {
return new Actions(env, table);
}
+ public static Actions forTable(StreamExecutionEnvironment env, TableLoader
tableLoader) {
+ return new Actions(env, tableLoader);
+ }
+
+ @Deprecated
public static Actions forTable(Table table) {
return new
Actions(StreamExecutionEnvironment.getExecutionEnvironment(CONFIG), table);
}
+ public static Actions forTableLoad(TableLoader tableLoader) {
Review Comment:
nit: forTableLoader
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
