ajantha-bhat commented on code in PR #13189: URL: https://github.com/apache/iceberg/pull/13189#discussion_r2189940895
########## format/spec.md: ########## @@ -101,10 +101,10 @@ Inheriting the sequence number from manifest metadata allows writing a new manif Row-level deletes are stored in delete files. -There are two ways to encode a row-level delete: - -* [_Position deletes_](#position-delete-files) mark a row deleted by data file path and the row position in the data file Review Comment: > I probably won't agree with changing it to three ways here. https://iceberg.apache.org/spec/#delete-formats The spec itself mention in down that "There are three types of row-level deletes:". I agree that there are two kinds of deletes, position deletes and equality deletes. But encoding is really different. So, maybe ok to mention `three` here? If we are ok with three, current changes are good? > I do agree the problem the link to position delete files. We probably should remove the files from the linked section titles. In the position deletes section, the two types of file format can be described there. currently it is ``` ### Delete Formats #### Deletion Vectors #### Position Delete Files #### Equality Delete Files ``` Are you suggesting to change? ``` ### Delete Formats #### Position Deletes ##### Deletion Vectors -- moved under new section Position Deletes ##### Position Delete Files -- moved under new section Position Deletes #### Equality Delete Files ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
