ForeverAngry commented on code in PR #2143: URL: https://github.com/apache/iceberg-python/pull/2143#discussion_r2191155682
########## pyiceberg/table/maintenance.py: ########## @@ -0,0 +1,372 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +from __future__ import annotations + +import logging +from typing import TYPE_CHECKING, List, Optional, Set + +from pyiceberg.manifest import DataFile, ManifestFile +from pyiceberg.utils.concurrent import ThreadPoolExecutor # type: ignore[attr-defined] + +logger = logging.getLogger(__name__) + + +if TYPE_CHECKING: + from pyiceberg.table import Table + from pyiceberg.table.metadata import TableMetadata + + +class MaintenanceTable: + tbl: Table + + def __init__(self, tbl: Table) -> None: + self.tbl = tbl + + try: + import pyarrow as pa # noqa + except ModuleNotFoundError as e: + raise ModuleNotFoundError("For metadata operations PyArrow needs to be installed") from e + + def expire_snapshot_by_id(self, snapshot_id: int) -> None: + """Expire a single snapshot by its ID. + + Args: + snapshot_id: The ID of the snapshot to expire. + + Raises: + ValueError: If the snapshot does not exist or is protected. + """ + with self.tbl.transaction() as txn: + # Check if snapshot exists + if not any(snapshot.snapshot_id == snapshot_id for snapshot in txn.table_metadata.snapshots): + raise ValueError(f"Snapshot with ID {snapshot_id} does not exist.") + + # Check if snapshot is protected + protected_ids = self._get_protected_snapshot_ids(txn.table_metadata) + if snapshot_id in protected_ids: + raise ValueError(f"Snapshot with ID {snapshot_id} is protected and cannot be expired.") + + # Remove the snapshot + from pyiceberg.table.update import RemoveSnapshotsUpdate + + txn._apply((RemoveSnapshotsUpdate(snapshot_ids=[snapshot_id]),)) + + def expire_snapshots_by_ids(self, snapshot_ids: List[int]) -> None: + """Expire multiple snapshots by their IDs. + Review Comment: ill check if it exists upstream, if it does i can ill refactor to `expire_snapshots` (i will also check if that exists upstream.). otherwise i will make it private! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
