ZENOTME commented on PR #1490: URL: https://github.com/apache/iceberg-rust/pull/1490#issuecomment-3048478697
> > > so I think there is no case that SnapshotProducer has different table with TransactionAction::commit? > > > > > > This is correct. In this case, can we refactor `SnapshotProducer::validate_added_data_files` and `SnapshotProducer::validate_duplicate_files` as well? If SnapshotProducer already hold a `Table` reference, then those functions can also be simplified. > > cc @ZENOTME Do you want to change it in this pr or do it in following pr? Yes, I will change it later -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
