lliangyu-lin commented on code in PR #467:
URL: https://github.com/apache/iceberg-go/pull/467#discussion_r2195720556
##########
partitions.go:
##########
@@ -28,7 +28,7 @@ import (
)
const (
- partitionDataIDStart = 1000
+ PartitionDataIDStart = 1000
InitialPartitionSpecID = 0
)
Review Comment:
It's used
[here](https://github.com/apache/iceberg-go/pull/467/files#diff-eb806166d1b9d570a36b8506d2b9ada56126a32ca94b1eb12d6de03973e292c2R54)
to when trying to get the last assigned partition field id across all
partition specs and that could be nil. And this is different than last assigned
id in the current spec, otherwise we could of use
https://github.com/apache/iceberg-go/blob/main/partitions.go#L200
Reference in python:
https://github.com/apache/iceberg-python/blob/main/pyiceberg/table/update/spec.py#L71
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
