ajantha-bhat commented on code in PR #13513: URL: https://github.com/apache/iceberg/pull/13513#discussion_r2197707885
########## format/spec.md: ########## @@ -970,7 +970,7 @@ Statistics files metadata within `statistics` table metadata field is a struct w | v1 | v2 | Field name | Type | Description | |----|----|------------|------|-------------| -| _required_ | _required_ | **`snapshot-id`** | `string` | ID of the Iceberg table's snapshot the statistics file is associated with. | +| _required_ | _required_ | **`snapshot-id`** | `long` | ID of the Iceberg table's snapshot the statistics file is associated with. | Review Comment: Aaah. Good catch. These puffin stats spec was approved 3 years ago. https://github.com/apache/iceberg/commit/4687798af7913f25dea9a1d6badd252f429a6810 I can see that [java](https://github.com/apache/iceberg/blob/main/api/src/main/java/org/apache/iceberg/StatisticsFile.java#L32) and [python](https://github.com/apache/iceberg-python/blob/479e6639103be367e218c16e83c22bc893400eb3/pyiceberg/table/statistics.py#L35) implementations use `long`. **But there can be some implementation out there that uses string (as per spec).** Also, at Iceberg we need mailing list discussion and [vote](https://iceberg.apache.org/contribute/?h=contributing#merging-pull-requests) for notable spec change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
