gaborkaszab commented on code in PR #13509: URL: https://github.com/apache/iceberg/pull/13509#discussion_r2199846533
########## spark/v4.0/spark/src/main/java/org/apache/iceberg/spark/actions/ExpireSnapshotsSparkAction.java: ########## @@ -79,6 +79,7 @@ public class ExpireSnapshotsSparkAction extends BaseSparkAction<ExpireSnapshotsS private Consumer<String> deleteFunc = null; private ExecutorService deleteExecutorService = null; private Dataset<FileInfo> expiredFileDS = null; + private Boolean cleanExpiredMetadata = null; Review Comment: The reason this is not a primitive is because in jobDesc() I'd like to differentiate between "not provided" and "provided as false" so that I can omit putting this info into the job desc when not provided. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
