amogh-jahagirdar commented on code in PR #13556:
URL: https://github.com/apache/iceberg/pull/13556#discussion_r2205984872
##########
core/src/main/java/org/apache/iceberg/util/SnapshotUtil.java:
##########
@@ -281,17 +282,21 @@ private static Iterable<Long> toIds(Iterable<Snapshot>
snapshots) {
return Iterables.transform(snapshots, Snapshot::snapshotId);
}
- public static List<DataFile> newFiles(
+ public static CloseableIterable<DataFile> newFiles(
Review Comment:
I think we should go through a deprecation cycle for this rather than
upfront changing it? We may have to introduce a new name to avoid the method
name collision, something like `addedDataFilesBetween`
I do agree though that we should keep the API minimal and the right return
type generally for this is an iterable of some sort rather than always eagerly
collecting every Data File entry in the range into a list, because that can
still be a lot.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
