wgtmac commented on code in PR #142:
URL: https://github.com/apache/iceberg-cpp/pull/142#discussion_r2206437585
##########
src/iceberg/catalog.h:
##########
@@ -166,8 +166,7 @@ class ICEBERG_EXPORT Catalog {
/// \param identifier a table identifier
/// \return instance of Table implementation referred to by identifier or
/// ErrorKind::kNoSuchTable if the table does not exist
- virtual Result<std::shared_ptr<Table>> LoadTable(
- const TableIdentifier& identifier) const = 0;
+ virtual Result<std::shared_ptr<Table>> LoadTable(const TableIdentifier&
identifier) = 0;
Review Comment:
```suggestion
virtual Result<std::unique_ptr<Table>> LoadTable(const TableIdentifier&
identifier) = 0;
```
nit: it is better to use std::unique_ptr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
